Repository navigation
Fix for the issue with multiple Terminate events in a single batch - #113
Merged
Simon Porter (simonporter) merged 1 commit intoAug 30, 2017
Merged
Conversation
…ent before the orchestration is picked up by dispatcher leads to a blocked orchestration (the processing keeps abandoning the orchestration). Only the first terminate request is honored and subsequent terminates are ignored. (That makes the fix simple and hopefully not a problematic behavior from user's perspective)
Pradeep Kadubandi (PradeepKadubandi)
requested a review
from Simon Porter (simonporter)
August 29, 2017 22:05
|
Pradeep Kadubandi (@PradeepKadubandi), |
Simon Porter (simonporter)
approved these changes
Aug 30, 2017
Pradeep Kadubandi (PradeepKadubandi)
added a commit
that referenced
this pull request
Sep 1, 2017
…ent before the orchestration is picked up by dispatcher leads to a blocked orchestration (the processing keeps abandoning the orchestration). (#113) Only the first terminate request is honored and subsequent terminates are ignored. (That makes the fix simple and hopefully not a problematic behavior from user's perspective)
zheg
pushed a commit
to zheg/durabletask
that referenced
this pull request
Mar 27, 2018
…ent before the orchestration is picked up by dispatcher leads to a blocked orchestration (the processing keeps abandoning the orchestration). (Azure#113) Only the first terminate request is honored and subsequent terminates are ignored. (That makes the fix simple and hopefully not a problematic behavior from user's perspective)
Simon Porter (simonporter)
pushed a commit
that referenced
this pull request
May 18, 2018
* Fix for the issue where issuing TerminateInstanceAsync twice from client before the orchestration is picked up by dispatcher leads to a blocked orchestration (the processing keeps abandoning the orchestration). (#113) Only the first terminate request is honored and subsequent terminates are ignored. (That makes the fix simple and hopefully not a problematic behavior from user's perspective) * Handle the case where an orchestration completes and terminates at the same time (#143)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the issue where issuing TerminateInstanceAsync twice from client before the orchestration is picked up by dispatcher leads to a blocked orchestration (the processing keeps abandoning the orchestration).
Only the first terminate request is honored and subsequent terminates are ignored. (That makes the fix simple and hopefully not a problematic behavior from user's perspective)